Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Halo5-Stats Spartan Company endpoint. #32

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

C-Kennelly
Copy link

Implements the Halo5.Stats "Company" endpoint and touches up some consistency in the original GetPlayerAppearance API, mostly swapping capitalization of field names from camelCase to match the API and other classes.

The referenced endpoint is documented at: https://developer.haloapi.com/docs/services/58acdf27e2f7f71ad0dad84b/operations/596968ade2f7f7051870d29f

This gist has some sample usage for the endpoint - https://gist.github.com/C-Kennelly/33d59b01db2a01201399cb41364e059c

Once again, I implemented identical unit tests to GetPlayerAppearance - covering the basics on matching expected URL, returning results that match the schema, and not throwing random exceptions. Probably could use some more tests here, if there's interest.

All unit tests were passing, though I think I missed the compile step that placed the JSON files in the /bin/debug folder and ended up doing copy-step that manually. If that's not IDE specific, you might run into the same problem when you run locally, so heads up.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
….cs Company class to be consistent with Halo5.Model.Stats.SpartanCompany.
… on InvalidGuid. All unit tests passing for GetSpartanCompany and GetPlayerAppearance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant