Add terms and privacy pages #131 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
🤖 OpenAI The changes introduce new components for Privacy Policy and Terms of Service pages, along with a shared banner component. These additions provide users with necessary legal information and enhance the overall user experience.
Chat with 🤖 OpenAI Bot (
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+8
to
+14
| export default function TermsOfService() { | ||
| return ( | ||
| <> | ||
| <PrivacyTermsBanner | ||
| title={metadata.title as string} | ||
| lastUpdated="2023-07-17" | ||
| /> |
There was a problem hiding this comment.
🤖 OpenAI
The lastUpdated prop in the PrivacyTermsBanner component is hardcoded to a specific date. This could lead to outdated information being displayed if the terms of service are updated but this date is not changed. Consider storing this date in a more centralized location or retrieving it from a backend service, if available.
Suggested change
| export default function TermsOfService() { | |
| return ( | |
| <> | |
| <PrivacyTermsBanner | |
| title={metadata.title as string} | |
| lastUpdated="2023-07-17" | |
| /> | |
| export default function TermsOfService() { | |
| const lastUpdated = "2023-07-17"; // Ideally, this should be fetched from a server or stored in a config file | |
| return ( | |
| <> | |
| <PrivacyTermsBanner | |
| title={metadata.title as string} | |
| lastUpdated={lastUpdated} | |
| /> |
samanyougarg
changed the title
samanyougarg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #131
Summary by OpenAI
New Feature:
Privacy PolicyandTerms of Servicepages to the application.PrivacyTermsBannercomponent that displays a banner with a title and last updated date.