Skip to content

Formatting #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Formatting #13

wants to merge 8 commits into from

Conversation

huey-tlatoani
Copy link
Contributor

@huey-tlatoani huey-tlatoani commented Apr 16, 2019

  • makes sure to use const and let on as much as possible

  • Fixes JSDoc

  • Removes YUI Compressor (incompatible with es6)

  • Uses Terser to compress the js file (to support es6)

  • Updates README command to clean, build and compress the files

  • Removes the grunt task "grunt-closure-compiler" as it doesn't seem to be used (it was using YUI instead)

  • Removes the JSDoc documentation (compiled docs) as it seems that was never there.

@harrymoore @uzquiano @cloudcms

Sorry I needed to recreate this after running the tests

cloudcms and others added 3 commits April 1, 2019 10:31
- Fixes JSDoc
- Removes YUI Compressor
- Uses Terser to compress the js file
- Updates README command to clean, build and compress the files
- Removes the grunt task "grunt-closure-compiler" as it doesn't seem to be used (it was using YUI instead)
@uzquiano
Copy link
Member

Hi Juan,

I'd like to get this merged in the near term. You put a lot of work in here and it looks really good. We hadn't updated the JS driver's build dependencies and I appreciate what you've done to improve that.

My sense is that we could merge this PR and then further address the NPM audit you mentioned in the other ticket.

Have you been using this version in your code? Or building from master? I'm just curious if the build product here passed tests or if you've tried it out and it seemed to work relatively well. We'll have to run it through the full test suite but based on what I see, I don't see why it wouldn't pass in short order.

Cheers,

Michael

@huey-tlatoani
Copy link
Contributor Author

huey-tlatoani commented Jul 4, 2019

Hi,

I couldn't really run all the tests.

I followed the instructions but it has errors trying to connect to test.cloudcms.com and starting a server, so I changed the server configuration to localhost and the it has issues with the proxy server.

I've currently been using the npm version, since I could not get the tests to run. Is the documentation to run the tests outdated?

…driver into formatting

# Conflicts:
#	bower.json
#	component.json
#	dist/gitana.js
#	js/gitana/Gitana.js
#	package.json
Changes the Proxy host since the .com address is not longer available
…driver into formatting

# Conflicts:
#	js/gitana/cluster/Cluster.js
#	package.json
@huey-tlatoani
Copy link
Contributor Author

  • Pulled the latest code from Master.

  • Changed the proxy server for the tests from test.cloudcms.com to test.cloudcms.net since the .com domain is not responding.

  • Still having issues connecting to the proxy server.

@huey-tlatoani
Copy link
Contributor Author

I was able to use Chrome's Local Override feature to load the changes onto CloudCMS and everything seems to be loading just fine.

…driver into formatting

� Conflicts:
�	bower.json
�	component.json
�	js/gitana/repository/Node.js
�	package.json
- Adds the package-lock.json file

Signed-off-by: Tenorio Arzola, Juan <16966425+tenoriojuann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants