fixing the SVG support #528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix works great for me! Looking forward to having a new release with this merged |
This was referenced Aug 15, 2019
Closed
|
Thanks @RicardoNiepel ! Issue is fixed in Version 3.0 Previous version:
Version 3.0:
|
gitbrent
added a commit
that referenced
this pull request
Sep 24, 2019
Closed
gitbrent
added a commit
that referenced
this pull request
Sep 24, 2019
Also Pull #528 was the main fix here
ericrockey
pushed a commit
to WeTransfer/PptxGenJS
that referenced
this pull request
Mar 24, 2020
ericrockey
pushed a commit
to WeTransfer/PptxGenJS
that referenced
this pull request
Mar 24, 2020
Also Pull gitbrent#528 was the main fix here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently multiple bugs inside the code base for the SVG support:
This PR fixes all - now the real SVG is used inside the pptx.
You can easily test it with 'pptxgenjs-demo.html': just scale the SVGs before and after this PR.