Skip to content

Commit

Permalink
Fix: Base icon CSS (#4193)
Browse files Browse the repository at this point in the history
- Fix top margin for unfolded base row
- Fix CSS variables (added new, remove ununsed)
  • Loading branch information
PavelLaptev authored Jun 26, 2024
1 parent 41b1b93 commit 900316a
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 12 deletions.
19 changes: 8 additions & 11 deletions app/src/lib/commit/CommitList.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -247,24 +247,21 @@
/* border-bottom: 1px solid var(--clr-border-2); */
--base-top-margin: 8px;
--base-icon-top: 16px;
--base-unfolded: 48px;
--base-row-height: 20px;
--base-row-height-unfolded: 48px;
--base-icon-top: -8px;
--avatar-first-top: 50px;
--avatar-top: 16px;
}
/* .commit-group {
padding-right: 14px;
padding-left: 8px;
} */
/* BASE ROW */
.base-row-container {
display: flex;
flex-direction: column;
height: 20px;
height: var(--base-row-height);
overflow: hidden;
transition: height var(--transition-medium);
Expand All @@ -281,8 +278,8 @@
}
.base-row-container_unfolded {
height: var(--base-unfolded);
--base-icon-top: 20px;
--base-row-height: var(--base-row-height-unfolded);
--base-icon-top: -3px;
& .base-row__text {
opacity: 1;
Expand All @@ -293,7 +290,7 @@
display: flex;
gap: 8px;
border-top: 1px solid var(--clr-border-3);
min-height: calc(var(--base-unfolded) - var(--base-top-margin));
min-height: calc(var(--base-row-height-unfolded) - var(--base-top-margin));
margin-top: var(--base-top-margin);
transition: background-color var(--transition-fast);
}
Expand Down
4 changes: 3 additions & 1 deletion app/src/lib/commitLines/BaseNode.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
height: 16px;
width: 16px;
margin-top: -8px;
margin-top: var(--base-icon-top);
margin-bottom: -8px;
margin-left: -9px;
margin-right: -7px;
Expand All @@ -40,6 +40,8 @@
display: flex;
align-items: center;
justify-content: center;
transition: margin-top var(--transition-medium);
}
}
</style>

0 comments on commit 900316a

Please sign in to comment.