assure benches do not rot
#4651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`check.sh` could not be found anywhere in the codebase.
|
@Byron is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
This way, it's not possible anymore to accidentally break code just because CI doesn't try to build it. Note that this is unrelated to features, which would still need to be specified or built individually by CI.
krlvi
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4632 introduced benchmarks which might stop working as they are not executed on CI, nor do I think they are tested by CI right now.
This PR validates this assumption and corrects it.
There maybe some minor cleaups if other issues are found.
Tasks
benchesare tested - they are not.Notes
rust-lintas it now runscargo-checkon Linux as well. Previously it was only used on Windows. Overall, it doesn't increase the runtime though and if that was a concern, one could probably try not to use docker to save time for the initial setup.scripts/check.shwas deleted as it is unused. It's also not used during publishing as far as I can tell, even though there other scripts are used which can be found by the usual means.