Fix complete app breakage due to BString serialization #4658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p/git2-to-gix"" This reverts commit 88496e6.
|
@Byron is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
This reverts commit 3043f09. We actually need this - me removing it just means it wasn't properly documented and clarified in the type-system as to why this is needed.
…quence of numbers. Instead, we need it to be a string, even if lossy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #4657, this brings back previously reverted improvements and assures that BString will never be serialized as sequence of bytes, something the UI will not be able to interpret as string.
This PR will also put safeties in place to assure an over-eager future me does that again.
Tasks
BStringcannot be mis-interpreted againNotes
Previously I managed to not correctly communicate in code the
BStringserialization 'specialty' (it serializes as array of bytes), and managed to undo it in a refactoring step. Now this case is handled by its own type which would make it very hard for me or others to make the same mistake - now it's clearly communicate why the type exists.It's also a nice marker that signals that the backend (which probably should be frontend agnostic eventually) is using frontend specific types in its API.