Add tests for resolving indexes #4973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Caleb-T-Owens
force-pushed
the
Testing-rebase
branch
from
af4c19d
to
a8e0eb4
Compare
Caleb-T-Owens
changed the title
Caleb-T-Owens
force-pushed
the
Testing-rebase
branch
from
a686f45
to
f74f2dc
Compare
krlvi
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces some tests for the
resolve_indexfunction. I moved the testing helper functions from upstream_integration and moved them into the testsupport crate. It seems like rust-analyzer can't quite figure out types for things in the test support crate which is a little bit bothersome, but seems to be a known issue rust-lang/rust-analyzer#14167.