Skip to content
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.

Prevents injection of inline.js by Metamask on certain pages #20

Closed
charlieknoll opened this issue Dec 21, 2017 · 0 comments · Fixed by #32
Closed

Prevents injection of inline.js by Metamask on certain pages #20

charlieknoll opened this issue Dec 21, 2017 · 0 comments · Fixed by #32

Comments

@charlieknoll
Copy link

With both gitcoin and metamask extensions installed and navigating to this url (https://charlieknoll.github.io/ethtracker.html?balance=1) web3 is not properly injected and the metamask extension logs 3 errors in the console "web3 is not defined".

Disable gitcoin extension and web3 is injected correctly. Maybe gitcoin is creating a web3 object?
gasolin added a commit to gasolin/chrome_ext that referenced this issue Jan 2, 2018
@gasolin
scope content scripts to github domain only and add permission to com…
bc44985 
…municate to addon from github pages, fix gitcoinco#20
@gasolin gasolin mentioned this issue Jan 2, 2018
Merged
@owocki owocki closed this as completed in #32 Jan 2, 2018
owocki added a commit that referenced this issue Jan 2, 2018
@owocki
Merge pull request #32 from gasolin/scope
939e7f1 
scope content scripts to github domain only, fix #20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scope content scripts to github domain only, fix #20 gasolin/chrome_ext
1 participant
@charlieknoll