Skip to content
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.

update jquery to 3.x #39

Closed
gasolin opened this issue Jan 23, 2018 · 1 comment
Closed

update jquery to 3.x #39

gasolin opened this issue Jan 23, 2018 · 1 comment

Comments

@gasolin
Copy link
Collaborator

gasolin commented Jan 23, 2018

When running npm run lint, the web_ext lint report jquery (1.x) version is old and is unsafe, which block us to list the extension on Firefox addons. (#1)

Should update jquery to 3.x and add a script to update it.
@gasolin
Copy link
Collaborator Author

gasolin commented Jan 23, 2018

While test with jquery-migrate, there're 3 compatibility issues when upgrade from jquery 1.x:

  • JQMIGRATE: jQuery.fn.click() event shorthand is deprecated
  • JQMIGRATE: jQuery.fn.keypress() event shorthand is deprecated
  • JQMIGRATE: jQXHR.error is deprecated and removed

@owocki owocki closed this as completed in 8500f07 Jan 23, 2018
owocki added a commit that referenced this issue Jan 23, 2018
@owocki
Merge pull request #40 from gasolin/jquery3
3fdd1a7 
update to Jquery3, fix #39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gasolin