Skip to content
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.

Should not use Synchronous XMLHttpRequest for fetching data #42

Closed
gasolin opened this issue Jan 25, 2018 · 5 comments
Closed

Should not use Synchronous XMLHttpRequest for fetching data #42

gasolin opened this issue Jan 25, 2018 · 5 comments

Comments

@gasolin
Copy link
Collaborator

gasolin commented Jan 25, 2018

Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user’s experience. For more help http://xhr.spec.whatwg.org/

If user intalled chrome_ext, The github page will hang a while when user's network speed is not fast enough.
@xwartz
Copy link

xwartz commented Jan 31, 2018

+1

@owocki
Copy link
Contributor

owocki commented Jan 31, 2018

related : #43

@owocki
Copy link
Contributor

owocki commented Jan 31, 2018

03307f8

@owocki
Copy link
Contributor

owocki commented Jan 31, 2018

publishing to the chrome store now

@gasolin
Copy link
Collaborator Author

gasolin commented Apr 23, 2018 •
edited
Loading

functions.js still using sync XMLHttpRequest, we should fix that as well

@gasolin gasolin mentioned this issue Apr 23, 2018
Open
gasolin added a commit to gasolin/chrome_ext that referenced this issue May 5, 2018
@gasolin
use fetch instead of sync XMLHttpRequest, fix gitcoinco#42
a5c32a0
gasolin added a commit to gasolin/chrome_ext that referenced this issue May 29, 2018
@gasolin
use fetch instead of sync XMLHttpRequest, fix gitcoinco#42
677932b
@arku arku closed this as completed in 77da801 Jun 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@owocki @gasolin @xwartz