-
-
Notifications
You must be signed in to change notification settings - Fork 30
1. Change ETH Symbol | 2. Add Theme Select Options | 3. Fix Issue #21 #23
base: master
Are you sure you want to change the base?
Conversation
Should the USD symbol be changed to the Ether ticker symbol?
Any particular reason "if" and "else if" is alternated in the
|
yes, thanks! |
not by design. its good to change this! |
note to future self: discussion about the color scheme ongoing here => #16 |
@@ -0,0 +1,29 @@ | |||
<!DOCTYPE html> | |||
<html> | |||
<head><title>Gitcoin - Pushing Open Source Forward</title></head> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add <meta charset="utf-8">
for encoding hint
|
||
<html> | ||
<head> | ||
<title>Gitcoin</title> | ||
<style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please pull the latest commit, this section is moved to a separate file
let theme = store.theme | ||
switch (theme) { | ||
case 'light': | ||
$('#bot').append('<img src="images/bot.png">'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try use plain createElement('img')
instead because firefox extension treat $.append
as an unsafe method.
@@ -124,9 +24,8 @@ | |||
<div class="bot_desc"> | |||
<h4 id="username"></h4> | |||
<p><strong>Address:</strong> <a id="address" target=_blank href="#">Unknown</a></p> | |||
<p><strong>Balance: </strong> <span id="balance">0</span> $ETH</p> | |||
<p><strong>Balance: </strong> <span id="balance">0</span> ΞETH</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@kamescg could you help rebase the PR? |
Should the USD symbol be changed to the Ether symbol?