Skip to content
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.

1. Change ETH Symbol | 2. Add Theme Select Options | 3. Fix Issue #21 #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kamescg
Copy link
Contributor

@kamescg kamescg commented Dec 27, 2017

Should the USD symbol be changed to the Ether symbol?

kamescg and others added 2 commits December 26, 2017 22:11
@kamescg kamescg changed the title Change $ to Ξ symbol - Global Community Friendly 1. Add Theme Select Options | 2. Change ETH Symbol Dec 27, 2017
@kamescg kamescg changed the title 1. Add Theme Select Options | 2. Change ETH Symbol 1. Change ETH Symbol | 2. Add Theme Select Options | 3. Fix Issue #21 Dec 27, 2017
@kamescg
Copy link
Contributor Author

kamescg commented Dec 27, 2017

Any particular reason "if" and "else if" is alternated in the body.js file?

    // Location | User Profile
    if(isOnUserProfile && !isAlreadyGitcoinBounty ){
        addButtonToUserPage();
    }
    // Location | Issue Page
    if (isOnIssuePage){
        addButtonToIssuePage();
        addBountyInfoToIssuePage(url);
        injectGetBountyAmount();
    } else if (isOnRepo){
        var repoUrl = document.location.href.split('issues')[0].split('pulls')[0];
        injectGetNumberBounties(repoUrl);
    } else if (isOnGitHub){
        injectGetTotalBounties();
    } 
    if (isOnIssuesPage) {
        injectGetAllBountiesOnIssuesPage();
    }
    if (isOnIssueBoard) {
        injectGetAllBountiesOnIssueBoard(); 
    }

@owocki
Copy link
Contributor

owocki commented Dec 27, 2017

Should the USD symbol be changed to the Ether symbol?

yes, thanks!

@owocki
Copy link
Contributor

owocki commented Dec 27, 2017

Any particular reason "if" and "else if" is alternated in the body.js file?

not by design. its good to change this!

@owocki
Copy link
Contributor

owocki commented Dec 27, 2017

note to future self: discussion about the color scheme ongoing here => #16

@@ -0,0 +1,29 @@
<!DOCTYPE html>
<html>
<head><title>Gitcoin - Pushing Open Source Forward</title></head>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add <meta charset="utf-8"> for encoding hint


<html>
<head>
<title>Gitcoin</title>
<style>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please pull the latest commit, this section is moved to a separate file

let theme = store.theme
switch (theme) {
case 'light':
$('#bot').append('<img src="images/bot.png">');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try use plain createElement('img') instead because firefox extension treat $.append as an unsafe method.

@@ -124,9 +24,8 @@
<div class="bot_desc">
<h4 id="username"></h4>
<p><strong>Address:</strong> <a id="address" target=_blank href="#">Unknown</a></p>
<p><strong>Balance: </strong> <span id="balance">0</span> $ETH</p>
<p><strong>Balance: </strong> <span id="balance">0</span> ΞETH</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gasolin
Copy link
Collaborator

gasolin commented Jan 31, 2018

@kamescg could you help rebase the PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants