Skip to content
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.

simplify the body check flow #26

Merged
merged 1 commit into from
Jan 10, 2018
Merged

simplify the body check flow #26

merged 1 commit into from
Jan 10, 2018

Conversation

gasolin
Copy link
Collaborator

@gasolin gasolin commented Dec 27, 2017

simplify body check flow since we already checked isOnGitHub at the top. Also passed url for process from setInterval function.

All function should work the same as 0.904 version

@gasolin
Copy link
Collaborator Author

gasolin commented Dec 29, 2017

@owocki @jclancy93 could you help review this?

@jclancy93
Copy link
Contributor

This all looks good to me, thanks for doing this. The body function definitely needed to be cleaned up.

var repoUrl = document.location.href.split('issues')[0].split('pulls')[0];
injectGetNumberBounties(repoUrl);
} else if (isOnGitHub){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@gasolin
Copy link
Collaborator Author

gasolin commented Jan 4, 2018

@owocki since @jclancy93 already reviewed this, could you help merge it?

@owocki
Copy link
Contributor

owocki commented Jan 10, 2018

thanks @gasolin !

@owocki owocki merged commit e3463cc into gitcoinco:master Jan 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants