GITC-237: Alters matching pool contribution to be an "on-top" donation #9444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdixon
requested review from
chibie,
frankchen07,
octavioamu,
PixelantDesign,
thelostone-mc and
zlsgh
as code owners
| @@ -1935,7 +1935,7 @@ def psave_contrib(sender, instance, **kwargs): | |||
| "from_profile":instance.subscription.contributor_profile, | |||
| "org_profile":instance.subscription.grant.org_profile, | |||
| "to_profile":instance.subscription.grant.admin_profile, | |||
| "value_usd":instance.subscription.amount_per_period_usdt if instance.subscription.amount_per_period_usdt else instance.subscription.get_converted_amount(False), | |||
| "value_usd":instance.subscription.amount_per_period_usdt if instance.subscription.amount_per_period_usdt else instance.subscription.get_converted_amount(True), | |||
| "url":instance.subscription.grant.url, | |||
| "network":instance.subscription.network, | |||
| "txid":instance.subscription.split_tx_id, | |||
There was a problem hiding this comment.
^ why are making the changes here ?
There was a problem hiding this comment.
I think is to ignore the gitcoin fee there as is already on the value ?
There was a problem hiding this comment.
Yeah thats right @octavioamu! Passing ignore_gitcoin_fee=True will make sure we get the full contribution value (without deducting the matching pool contrib)
octavioamu
approved these changes
Sep 7, 2021
jeremyschuurmans
pushed a commit
that referenced
this pull request
Sep 22, 2021
#9444) * GITC-237: Alters matching pool contribution to be an "on-top" donation * Puts polygon mention behind staff flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the interim checkout experience. The matching pool contribution has been altered to be an "on-top" donation.
Refers/Fixes
Fixes: GITC-237
Testing
Tested locally