Skip to content

Please fire pre-commit hooks at appropriate times #392

Open
@SteveRuble

Description

@SteveRuble

Please complete the following tasks

  • I have searched the discussions
  • I have searched the existing issues

Version

git-stack 0.10.18

Use Case

I have a number of linting tools I run as pre-commit hooks to avoid needing to clean things up later but I can't figure out how to retain that workflow with git-stack.

Requirements

I think that pre-commit hooks ought to be run whenever git-commit runs, and as I understand it git-stack's git-amend is intended to be git commit --amend --no-edit + extra special features, so I expected it to trigger my pre-commit hooks. I don't think that I can use the post-rewrite hook that git-stack currently fires, because I only want to lint files that are changing and after a rewrite there's no way to tell which files were changed (or at least no obvious, standard way that my linters will understand).

Possible Solutions

Can git-stack be taught to fire the pre-commit hook during git-amend, before actually applying the changes, and aborting if the hook fails?

I don't think that any other commands should fire pre-commit hooks, but I've just started using this tool and maybe I'm missing something.

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionUncertainty is involved

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions