Detect possible commit hashes in the commit messages and convert them to hyperlinks #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…10 limitation comes from LinkFactory
…hes. 7 is the default length for short hashes according to http://git-scm.com/docs/git-rev-parse
| @@ -49,6 +50,8 @@ public static CommitInformation GetCommitInfo(CommitData data, bool showRevision | |||
| string header = data.GetHeader(showRevisionsAsLinks); | |||
| string body = "\n" + WebUtility.HtmlEncode(data.Body.Trim()); | |||
|
|
|||
| if (showRevisionsAsLinks) | |||
| body = GitRevision.Sha1HashShortRegex.Replace(body, m => LinkFactory.CreateCommitLink(m.Value)); | |||
There was a problem hiding this comment.
Will it replace full 40 char hash with the first 10 chars?
There was a problem hiding this comment.
Thanks @Radrik5 I fixed that
|
Please consider using 'git rev-parse --verify hash^{commit}' to ignore false positive matches. |
…ive matches. 7 is the default length for short hashes according to http://git-scm.com/docs/git-rev-parse" This reverts commit e63b2a2.
Conflicts: Externals/Git.hub
KindDragon
force-pushed
the
master
branch
8 times, most recently
from
f479657
to
3ba72ae
Compare
jbialobr
reviewed
Mar 15, 2017
| { | ||
| if (module == null) | ||
| return hash; | ||
| string revParseResult = module.RunGitCmd(string.Format("rev-parse --verify --quiet {0}^{{commit}}", hash)); |
There was a problem hiding this comment.
Checking if hash is valid should be implemented in GitModule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2714