Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worktree: add completion for the rev argument in git worktree add <path> <rev> #82

Closed
wants to merge 1 commit into from

Conversation

dscho
Copy link
Member

@dscho dscho commented Nov 16, 2018

This is inspired by one of those half-finished contributions in the Git for Windows project. Fall cleaning, if you like.

The second non-option argument to `git worktree`'s `add` command is an
optional revision. Let's complete it.

Inspired by git-for-windows#1681.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member Author

dscho commented Nov 16, 2018

This does not qualify for a bug fix, so I guess I should hold off until Git v2.20.0 is out.

@dscho
Copy link
Member Author

dscho commented Dec 10, 2018

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 10, 2018

Submitted as pull.82.git.gitgitgadget@gmail.com

@dscho dscho added the needs-work These patches have pending issues that need to be resolved before submitting label Dec 15, 2018
@dscho
Copy link
Member Author

dscho commented Jan 18, 2019

This will need substantial re-work: https://public-inbox.org/git/20181211023449.GS30222@szeder.dev/

@dscho
Copy link
Member Author

dscho commented May 8, 2020

This re-work was actually done by @szeder and it was accepted into git.git as 7d5ecd7.

@dscho dscho closed this May 8, 2020
@dscho dscho deleted the complete-worktree-add branch May 8, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-work These patches have pending issues that need to be resolved before submitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant