[engine] feature/712 브랜치에서 작업한 내용을 main 브랜치에 반영 #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytaek
requested changes
Oct 10, 2024
There was a problem hiding this comment.
음. 지금 @yoouyeon 님이 계속 update 하고 있는 gitlog parsing 부분이 들어간 것 같은데,
해당 부분은 아직 작업중인 걸로 알고 있는데 아닐까요?
git log parsing 부분은 완료가 되면 가져오면 좋을 것 같고,
우선은 @BeA-Pro 님이 작업해주신 부분만 따로 merge 되는게 좋아보입니다. ㅜ.ㅜ
이미 merge 를 다 하신 것 같아서 죄송하지만, log parser 부분 완료가 되어야 master에 같이 머지되는게 맞는 것 같습니다.
혹시 다른 의견 or 내부적으로 논의하신 내용들이 있다면 말씀 부탁드리겠습니다!
Comment on lines
224
to
225
| const commitCount = parseInt(stdout.toString().trim(), BASE_10); // Buffer를 문자열로 변환 후 숫자로 변환 | ||
| resolve(commitCount); // 숫자를 반환 |
There was a problem hiding this comment.
한글 주석은 영어로 변경하거나,
필요없다면 삭제하는게 좋을 것 같습니다!
Comment on lines
243
to
246
| if (totalCnt > taskThreshold) { | ||
| if (numCores < coreCountThreshold) numberOfThreads = 2; | ||
| else numberOfThreads = 3; | ||
| } |
There was a problem hiding this comment.
? indentation 이 뭔가 안 맞는 느낌이네용?
| const skipCount = i * chunkSize; | ||
| const limitCount = chunkSize; | ||
|
|
||
| console.log('__dirname:', __dirname); |
There was a problem hiding this comment.
정리하는 김에 console log도 정리해주면 좋을 것 같습니다.
필요한 것 or 런타임 디버깅에 유용한건 놔두고(혹은 부가 설명을 더 넣고), 나머지는 삭제하면 좋겠습니다
ytaek
approved these changes
Nov 9, 2024
| @@ -7,6 +7,7 @@ import { GithubTokenUndefinedError, WorkspacePathUndefinedError } from "./errors | |||
| import { deleteGithubToken, getGithubToken, setGithubToken } from "./setting-repository"; | |||
| import { mapClusterNodesFrom } from "./utils/csm.mapper"; | |||
| import { | |||
| fetchGitLogInParallel, | |||
| @@ -197,6 +199,70 @@ export async function getGitLog(gitPath: string, currentWorkspacePath: string): | |||
| }); | |||
| } | |||
|
|
|||
| export async function getLogCount(gitPath: string, currentWorkspacePath: string): Promise<number> { | |||
seungineer
approved these changes
Nov 9, 2024
Comment on lines
+228
to
+237
| const totalCnt = await getLogCount(gitPath, currentWorkspacePath); | ||
| let numberOfThreads = 1; | ||
|
|
||
| const taskThreshold = 1000; | ||
| const coreCountThreshold = 4; | ||
|
|
||
| if (totalCnt > taskThreshold) { | ||
| if (numCores < coreCountThreshold) numberOfThreads = 2; | ||
| else numberOfThreads = 3; | ||
| } |
There was a problem hiding this comment.
수 많은 테스트로 도출한 최적의 파라미터 값! 👍👍👍👍
| entry: "./src/extension.ts", // the entry point of this extension, 📖 -> https://webpack.js.org/configuration/entry-context/ | ||
| entry: { | ||
| extension: "./src/extension.ts", // the entry point of this extension, 📖 -> https://webpack.js.org/configuration/entry-context/ | ||
| worker: "./src/utils/git.worker.ts" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Result
멀티 쓰레드 기법을 활용하여 깃 로그를 받아올 때의 속도를 약 30% 향상시켰습니다.