feat: Make Packer builder IAM role configurable #4342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgodbolt
changed the title
mattgodbolt
force-pushed
the
mg/builder_iam_profile
branch
from
7a524ec to
16e2eb6
Compare
|
Drafting after I spotted typos. That'll teach me to make any changes between my branch and a PR.... |
Allows the Packer build instance to access resources as a IAM role during the build process. Defaults to empty string, which should replicate existing behaviour. See github-aws-runners#3041.
mattgodbolt
force-pushed
the
mg/builder_iam_profile
branch
from
16e2eb6 to
d9ee487
Compare
|
Ready; sorry for the noise! |
mattgodbolt
referenced
this pull request
in compiler-explorer/ce-ci
Jan 8, 2025
The change in submodule /seems/ not to affect us (anymore?) - reverting it means the only difference between the submodule and the upstream version is just PR'd away in https://github.com/philips-labs/terraform-aws-github-runner/pull/4342 so we can in theory consider killing the submodule once that lands.
mattgodbolt
referenced
this pull request
in compiler-explorer/ce-ci
Jan 8, 2025
Reverts the yum/apt stuff in the submodule The change in submodule /seems/ not to affect us (anymore?) - reverting it means the only difference between the submodule and the upstream version is just PR'd away in philips-labs/terraform-aws-github-runner#4342 so we can in theory consider killing the submodule once that lands. cc @partouf I built both the arm64 and x64 and did test builds on both. They seem to work.
|
Thx but this looks a duplicate of #4278 which I just merged. |
|
Wow it absolutely is :) thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the Packer build instance to access resources as a IAM role during the build process. Defaults to empty string, which should replicate existing behaviour.
See #3041.