-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Writing some (failing) tests for instrumentation
- Loading branch information
Showing
1 changed file
with
43 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
require_relative "./helper" | ||
|
||
class TestInstrumentation < Minitest::Test | ||
include Linguist | ||
|
||
class LocalInstrumenter | ||
Event = Struct.new(:name, :args) | ||
|
||
attr_reader :events | ||
|
||
def initialize | ||
@events = [] | ||
end | ||
|
||
def instrument(name, *args) | ||
@events << Event.new(name, args) | ||
end | ||
end | ||
|
||
def setup | ||
Linguist.instrumenter = LocalInstrumenter.new | ||
end | ||
|
||
def teardown | ||
Linguist.instrumenter = nil | ||
end | ||
|
||
def test_detection_instrumentation_with_binary_blob | ||
binary_blob = fixture_blob("Binary/octocat.ai") | ||
Language.detect(binary_blob) | ||
|
||
# Shouldn't instrument this (as it's binary) | ||
assert_equal 0, Linguist.instrumenter.events.size | ||
end | ||
|
||
def test_modeline_instrumentation | ||
blob = fixture_blob("Data/Modelines/ruby") | ||
Language.detect(blob) | ||
|
||
assert_equal 3, Linguist.instrumenter.events.size | ||
This comment has been minimized.
Sorry, something went wrong. |
||
assert_equal "linguist.detected", Linguist.instrumenter.events.last.name | ||
end | ||
end |
@bkeepers - I would expect three events here:
linguist.detection
linguist.strategy
(for the modeline detection)linguist.detected
when we return the classificationAny ideas why this might not be happening?