adding Lasso language and sample files

[stevepiercy]

Adding Lasso programming language, per GitHub Issue #234

[travisbot]

This pull request fails (merged 3b558db into a41f40a).

[travisbot]

This pull request fails (merged 21a7fe9 into a41f40a).

[travisbot]

This pull request fails (merged 29a0db4 into a41f40a).

[stevepiercy]

It looks like your version of pygments is over two months old. Please update!

pygments/pygments.rb#36

[josh]

You won't need to specify these extensions anymore when you provide samples. It looks like you have a .lasso and .lasso9. It'd be great to have ones for .las and .ldml.

[stevepiercy]

Thanks for the tip. I also updated the instructions at the top of the file accordingly.

[josh]

Looks mostly good. I can merge it after we get pygments updated. We're kinda in a weird spot cause we're testing a huge branch refactor of pygments.rb. So it might be another couple of weeks. I'll ping you back when its good.

[travisbot]

This pull request fails (merged 31d6b11 into a41f40a).

[stevepiercy]

Hi Joshua,

Thanks for the response. I can relate to the situation. Cheers!

--steve

On 8/19/12 at 8:21 AM, notifications@github.com (Joshua Peek) pronounced:

Looks mostly good. I can merge it after we get pygments
updated. We're kinda in a weird spot cause we're testing a huge
branch refactor of pygments.rb. So it might be another couple
of weeks. I'll ping you back when its good.

---

Reply to this email directly or view it on GitHub:
#235 (comment)

---

---

Steve Piercy Web Site Builder
Soquel, CA
web@StevePiercy.com http://www.StevePiercy.com/

[stevepiercy]

Has there been any progress on pygments.rb? Should I push a new commit to force Travis to run its tests?

[vendethiel]

Bumping again ?

[stevepiercy]

pygments.rb has updated to the latest pygments, and is now pulling in Lasso as a language.

pygments/pygments.rb#36

However the Travis build still fails. What can I do to get my pull request to pass the Travis build?

Perhaps a ping to @josh will help?

[stevepiercy]

@tnm Sorry for the crossed comments. Thank you for the follow-up!

[tnm]

Sorry for the delay. 0.3.7 is updated with new lexers and so is linguist, HEAD now green — https://travis-ci.org/github/linguist/builds/3913377

[stevepiercy]

@tnm The Travis build still fails. I'm not sure what to do.
https://travis-ci.org/github/linguist/builds/3913442

Does my branch 'lasso' need to be merged into 'master'?

[tnm]

@stevepiercy — I see it. linguist is still picking up 0.3.4. Bump the gemspec to say 0.3.7 and you should be set.

[tnm]

@stevepiercy — e.g., s.add_dependency 'pygments.rb', '>= 0.3.7'

We'll probably bump master soon also.

[tnm]

With that, tests will run fine. However I did also pull your branch down and you will probably see this:

Finished tests in 7.639346s, 10.8648 tests/s, 238.8948 assertions/s.

  1) Failure:
test_language(TestBlob) [/linguist/test/test_blob.rb:284]:
No language for /linguist/samples/Ecl/sample.ecl

83 tests, 1825 assertions, 1 failures, 0 errors, 0 skips

That failure seems to be related to changes in your branch (the Ecl language) so should be fixable!

[tnm]

@stevepiercy — Bit more help for you :) Looks like you have .inc, .dml and a couple other extensions in your sample directory, which are not registered (you just have *.lasso in the yaml file.

[tnm]

Tests pass cleanly for me when the only file type in the sample directory is json.lasso, or when the relevant extensions are added.

[tnm]

Awesome! I'm cool to merge this but I'll wait for @josh's 👍 as well since this includes the pygments.rb bump which is also covered by #331; in #331 it's changed to do pessimistic versioning (that PR could be merged after this one).

@josh — the relevant sample files here look good, and there are no extension name conflicts.

[stevepiercy]

@tnm THANK YOU! THANK YOU! THANK YOU! If I run into either you or @josh in person (not improbable since I attend SFPython meetups and PyCon), drinks/dinner is on me. Cheers!

[vendethiel]

@stevepiercy gg !
@tnm #324 pretty please ?

[tnm]

Alright, I have a cleaned-up rebased version of this branch (sans the pygments.rb version change) ready to go whenever.

[stevepiercy]

@josh May I please have a 👍 from you for this pull request? Thank you!

[tnm]

Merged in adc9246