Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license hashes following Licensee update #4248

Merged

Conversation

pchaigno
Copy link
Contributor

While we're trying to handle this better in the long term (cf. licensee/licensee#328), this pull request updates the hardcoded license hash values in the tests and fixes the Travis CI builds.

See licensee/licensee#328 for information on why the hash values changed. Basically, the hash values are computed over the normalized license text, so every time the normalization process changes, the values will change.

This pull request also removes two hardcoded license values that are not needed anymore.

@Alhadis
Copy link
Collaborator

Alhadis commented Aug 24, 2018

What's involved in normalising license text? What does it mean?

(I wanted to ask at licensee/licensee#328, but I don't have permissions to post a comment for some reason. 😕)

@pchaigno
Copy link
Contributor Author

What's involved in normalising license text? What does it mean?

Before comparing licenses, they remove text that doesn't have any particular semantic (such as bullet points) and text whose semantic doesn't matter to the recognition of the license (such as the Copyright line that includes the author's name).

but I don't have permissions to post a comment for some reason.

uh, that's very weird.

@Alhadis
Copy link
Collaborator

Alhadis commented Aug 24, 2018

Ah, now I see. 😀 Thanks!

Yeah, it is strange. 🤔 Maybe the repository's activity is currently limited to past contributors only.

@Alhadis Alhadis merged commit 5d1f205 into github-linguist:master Aug 25, 2018
@pchaigno pchaigno deleted the fix-travis-update-license-hashes branch August 25, 2018 11:54
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants