Display parsing errors in grammar compiler #4287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lildude
reviewed
Oct 9, 2018
tools/grammars/compiler/converter.go
Outdated
| @@ -65,6 +65,9 @@ func (conv *Converter) tmpScopes() map[string]bool { | |||
| func (conv *Converter) AddGrammar(source string) error { | |||
| repo := conv.Load(source) | |||
| if len(repo.Files) == 0 { | |||
| if len(repo.Errors) > 0 { | |||
| return fmt.Errorf("Parsing error in '%s': %s", source, repo.Errors[0]) | |||
| } | |||
There was a problem hiding this comment.
This feels a bit odd to me: "We found no grammar files, but hey, here's an error."
I'm mostly AFK this week so don't have time to dig into this deeper myself, but couldn't we check for errors in the first if, eg:
if len(repo.Files) == 0 && len(repo.Errors) == 0 {
return fmt.Errorf("source '%s' contains no grammar files", source)
}... and only return if we really don't find any files or errors and leave the error reporting for the check slightly further down if we do?
There was a problem hiding this comment.
Oh, right! That should work.
I'll update the pull request tonight.
There was a problem hiding this comment.
Done. I also updated the error message in the original post.
pchaigno
force-pushed
the
grammar-compiler-display-parsing-errors
branch
from
b78f398 to
b6b6ef2
Compare
|
@lildude I think this is ready to be merged 😃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display parsing errors in grammar compiler. Fixes #4141.
Here's how the error from #4141 would appear:
/cc @wesinator
Removed template as it doesn't apply.