-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert rust color change #4326
Revert rust color change #4326
Conversation
The previous change made it hard to distinguish and made it hard to recognize for all users that are used to the color. Practically speaking the change introduced more problems than the esthetics it wanted to solve gained us.
I am in favour of this. As has been mentioned in the comments of #4319 the deeper red colour is harder to distinguish from other languages (D, Ruby, Scala, etc.) while the original colour worked just fine. Also I do not believe that the #a62c00 shade has any real association with the Rust community. |
FWIW, I started a humorous thread over here discussing the change. It seems like most people favor the old color, although I don't have as strong of an opinion on this subject. I slightly favor the old color. |
I am in favor of this as well. The color that people would most associate with Rust would be that of its unofficial mascot, who is orange: http://rustacean.net Additionally, the rationale that the old color doesn't look like iron oxide is misguided since the language was named after the rust fungus, which also has an orange color: https://en.wikipedia.org/wiki/Rust_(programming_language)#History |
I, too, prefer the older colour. Please bring it back. Annoying that this change was done without the O.K. of the Rust team. |
I think Rust color is a better choice. |
I think the new color is 10000x better than the old one. The color suggested by @quininer could be a nice compromise though. |
the new colour is great and definitely better than the old one! |
It was a breaking change. We could revert it and then gradually change it to the new color over time, so no one will notice and/or complain (remember eBay, anyone?) 😅😋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good.
I am in favor of the old one as well. It's too dark and distinguishable from other languages. |
I'll try get this out today. |
This is now live on GitHub.com. |
The previous change #4319 made it hard to distinguish the language and made it hard to recognize for all users that are used to the old color. Practically speaking the change introduced more problems than the esthetics it wanted to solve gained us. Also esthetics are personal opinions, so I'd leave a new color up to the rust team to decide.