-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heuristic to disambiguate GAP and GDScript #4378
Conversation
GDScript files (.gd) are often misclassified as GAP code on Github.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
@anantn Could you add a test for these changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Pinging @fingolfin, who added support for both GAP and GDScript in Linguist (#1046 and #1529), in case they want to review.
Co-Authored-By: anantn <anant@kix.in>
If the heuristic doesn't match I think we should still classify the script as GAP since we would try other strategies as @pchaigno mentioned. But no harm making the heuristic more robust! Thanks to @fingolfin and @pchaigno for your help with this patch 👍 |
@pchaigno Could we land this now? 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
GDScript files (.gd) are often misclassified as GAP code on Github.
Description
This rule updates classification of .gd files as either GAP or GDScript. Currently, several GDScript files are misclassified as GAP on Github (example search: https://github.com/search?q=language%3AGAP+game&type=Repositories)
Checklist: