Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .jsonc extension #4797

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Add .jsonc extension #4797

merged 2 commits into from
Mar 10, 2020

Conversation

nathanshelly
Copy link
Contributor

@nathanshelly nathanshelly commented Feb 10, 2020

Marks .jsonc files as jsonc.

Checklist:

@nathanshelly
Copy link
Contributor Author

This PR adds the .jsonc extension that was in the initial draft of #4171. It was removed per this comment. I'm adding it back hoping that usage is high enough to accept it this time. Feel free to close out immediately if it isn't.

Alhadis added a commit to Alhadis/Silos that referenced this pull request Feb 11, 2020
Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage checks out this time.

nathanshelly added a commit to nathanshelly/.files that referenced this pull request Feb 16, 2020
Should have correct highlighting on GitHub assuming github-linguist/linguist#4797 is merged.
nathanshelly added a commit to nathanshelly/.files that referenced this pull request Feb 16, 2020
Should have correct highlighting on GitHub assuming github-linguist/linguist#4797 is merged.
@pchaigno pchaigno requested a review from lildude February 18, 2020 21:11
@lildude lildude merged commit 2a81510 into github-linguist:master Mar 10, 2020
@nathanshelly nathanshelly deleted the ns/jsonc-extension branch March 16, 2020 03:53
@nathanshelly
Copy link
Contributor Author

Could anyone explain how I would get GitHub to highlight this .jsonc file as jsonc? That was my intent with opening this PR, apologies for apparently misunderstanding how GitHub's highlighting works.

I see this section about issues with syntax highlighting but as far as I can tell the file isn't being recognized as a jsonc filetype so the issue happens before the upstream grammar is even applied.

@Alhadis
Copy link
Collaborator

Alhadis commented Mar 16, 2020

@nathanshelly Changes to Linguist don't become visible on GitHub until there's a new release, which @lildude is in the process of preparing. You'll see the highlighting once #4816 goes live.

@nathanshelly
Copy link
Contributor Author

🤦‍♂️ of course that makes perfect sense, thanks!

nathanshelly added a commit to nathanshelly/.files that referenced this pull request Oct 9, 2020
Should have correct highlighting on GitHub assuming github-linguist/linguist#4797 is merged.
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants