Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Swift color to match the official Swift logo #5405

Merged
merged 4 commits into from
Jul 19, 2021

Conversation

eneko
Copy link
Contributor

@eneko eneko commented Jun 1, 2021

Description

Update color for Swift programming language to match the orange from the official Swift logo (from swift.org)

Swift logo

Before: #ffac45
After: #F05138

Checklist:

Update color for Swift programming language to match the orange from the [official Swift logo](https://swift.org/assets/images/swift.svg) (from swift.org)
@eneko eneko requested a review from a team as a code owner June 1, 2021 21:43
@lildude
Copy link
Member

lildude commented Jun 24, 2021

🤔 this doesn't appear to be getting much community support in either direction.

@eneko
Copy link
Contributor Author

eneko commented Jun 24, 2021

Hi @lildude, unfortunately, not many hearts or thumbs up, agreed. But I haven't heard of anyone rejecting the change either.

I'll see if I can promote the change a bit more on Twitter and the forums, thank you.

@Trzyipolkostkicukru
Copy link

Trzyipolkostkicukru commented Jun 25, 2021

14 hearts on the forum isn't a tiny amount of hearts. Review for structured concurrency proposal received 19 hearts, and it's arguably the most exciting change to swift ever.

The lack of comments is there because there's not much to say other than "+1" which is explicitly discouraged

@eneko
Copy link
Contributor Author

eneko commented Jul 14, 2021

@lildude seems like there is enough support now?

@lildude
Copy link
Member

lildude commented Jul 14, 2021

If you're confident about it and happy to field any complaints for the change, if there are any, I'm happy for it to be merged.

@lildude
Copy link
Member

lildude commented Jul 19, 2021

Gonna merge this now. If there are any objections with the colour choice, please discuss this on the forum topic referenced in the OP as this is a community requested and supported change, not a GitHub/Linguist initiated change.

@lildude lildude merged commit e4aec15 into github-linguist:master Jul 19, 2021
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jul 19, 2021
@eneko eneko deleted the patch-1 branch July 23, 2021 23:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants