-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Swift color to match the official Swift logo #5405
Conversation
Update color for Swift programming language to match the orange from the [official Swift logo](https://swift.org/assets/images/swift.svg) (from swift.org)
🤔 this doesn't appear to be getting much community support in either direction. |
Hi @lildude, unfortunately, not many hearts or thumbs up, agreed. But I haven't heard of anyone rejecting the change either. I'll see if I can promote the change a bit more on Twitter and the forums, thank you. |
14 hearts on the forum isn't a tiny amount of hearts. Review for structured concurrency proposal received 19 hearts, and it's arguably the most exciting change to swift ever. The lack of comments is there because there's not much to say other than "+1" which is explicitly discouraged |
@lildude seems like there is enough support now? |
If you're confident about it and happy to field any complaints for the change, if there are any, I'm happy for it to be merged. |
Gonna merge this now. If there are any objections with the colour choice, please discuss this on the forum topic referenced in the OP as this is a community requested and supported change, not a GitHub/Linguist initiated change. |
Description
Update color for Swift programming language to match the orange from the official Swift logo (from swift.org)
Before:
#ffac45
After:
#F05138
Checklist: