Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECL language grammar #5424

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Conversation

GordonSmith
Copy link
Contributor

@GordonSmith GordonSmith commented Jun 14, 2021

Update samples folder

Signed-off-by: Gordon Smith GordonJSmith@gmail.com

Description

Adding grammar to existing ECL language
Updating samples for ECL language

Search results: https://github.com/search?q=extension%3Aecl+OUTPUT+DATASET&type=Code

Checklist:

  • I am associating a language with a new file extension.

  • I am adding a new language.

  • I am fixing a misclassified language

    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am changing the source of a syntax highlighting grammar

  • I am updating a grammar submodule

  • I am adding new or changing current functionality

    • I have added or updated the tests for the new or changed functionality.
  • I am changing the color associated with a language

    • I have obtained agreement from the wider language community on this color change.
      • [URL to public discussion]
      • [Optional: URL to official branding guidelines for the language]

@GordonSmith GordonSmith requested a review from a team as a code owner June 14, 2021 11:25
@GordonSmith GordonSmith force-pushed the ECL_II branch 7 times, most recently from e1de88f to e91c82e Compare June 14, 2021 12:33
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah!! We really don't need that many samples. We only need two or maybe three of the most representative real-world usage examples of the language. You also need to reference where the samples come from and the license they're covered by in the template in the OP.

We also don't change or remove samples already added, which raises the question: why are you removing the current sample?

Update ECL Samples

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith
Copy link
Contributor Author

@lildude - I reverted the "sample" change - I wrongly assumed that more was better somehow!

@GordonSmith GordonSmith requested a review from lildude June 14, 2021 13:09
@lildude lildude changed the title feat: Add latest ECL language grammar Add ECL language grammar Jun 24, 2021
@lildude lildude merged commit 808087b into github-linguist:master Jun 24, 2021
@GordonSmith GordonSmith deleted the ECL_II branch June 24, 2021 07:24
@lildude lildude mentioned this pull request Aug 4, 2021
1 task
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants