Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fennel #5441

Merged
merged 4 commits into from
Jul 11, 2021
Merged

Add Fennel #5441

merged 4 commits into from
Jul 11, 2021

Conversation

p00f
Copy link
Contributor

@p00f p00f commented Jul 4, 2021

Description

Adds the Fennel programming language

Checklist:

@p00f p00f requested a review from a team as a code owner July 4, 2021 06:16
@p00f
Copy link
Contributor Author

p00f commented Jul 4, 2021

The colour #fff3d7 is taken from the logo on https://fennel-lang.org

@p00f
Copy link
Contributor Author

p00f commented Jul 4, 2021

cc @technomancy @bakpakin

@lildude
Copy link
Member

lildude commented Jul 10, 2021

Usage checks out, just 😉:

Total files found: 2529
Unique public user/repos: 244
Unique owners: 182

@p00f
Copy link
Contributor Author

p00f commented Jul 11, 2021

@lildude Can you approve the checks?

@p00f
Copy link
Contributor Author

p00f commented Jul 11, 2021

The first one passed, sorry for merging again

@lildude lildude merged commit 2f322a9 into github-linguist:master Jul 11, 2021
@p00f
Copy link
Contributor Author

p00f commented Jul 11, 2021

Thanks!

@p00f
Copy link
Contributor Author

p00f commented Jul 12, 2021

Any idea when this will roll out?

@lildude
Copy link
Member

lildude commented Jul 12, 2021

I'm aiming for the week of 19 July.

@p00f
Copy link
Contributor Author

p00f commented Jul 12, 2021

Thanks

@p00f
Copy link
Contributor Author

p00f commented Aug 1, 2021

Should this be working by now (after 7.16.0 was released) ?

@lildude
Copy link
Member

lildude commented Aug 1, 2021

Not yet, as I'm not deploying to GitHub.com until tomorrow as stated in the release PR: #5489

@p00f
Copy link
Contributor Author

p00f commented Aug 1, 2021

Ah thanks

@lildude
Copy link
Member

lildude commented Aug 2, 2021

Now live.

@p00f
Copy link
Contributor Author

p00f commented Aug 2, 2021

Thanks!

bastienleonard added a commit to bastienleonard/dungeonesque-dungeons that referenced this pull request Aug 3, 2021
Its purpose was to tell GitHub to treat .fnl files as Clojure files. This is
not needed anymore, since GitHub now officially supports .fnl files:
github-linguist/linguist#5441
@p00f
Copy link
Contributor Author

p00f commented Oct 19, 2021

When I click on fennel here

image

it says "We couldn’t find any code matching '' in Olical/aniseed", did I miss something?
This bar doesn't have fennel either:
image

@Nixinova
Copy link
Contributor

GitHub Search uses an old version of Linguist so search results will always lag behind the language bar.

rktjmp pushed a commit to rktjmp/hotpot.nvim that referenced this pull request Nov 13, 2021
also used fennel for code sample instead of clojure, as it is supported
by Github syntax highlighting for quite a while now: github-linguist/linguist#5441
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants