Lock docker version and require set #5453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed yesterday that our tests have started failing:
This is caused by a missing
require "set"
that is needed for the use ofSet()
in the test. I'm not sure why this is suddenly an issue now without any changes. I can only think we were inadvertently getting this elsewhere.The docker build is also failing with:
This being tracked upstream in https://gitlab.alpinelinux.org/alpine/aports/-/issues/12763 and the workaround is to lock to an earlier version of Alpine, which I'm doing by locking us to 3.13.