-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Roc Language #6633
Add Roc Language #6633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can get this in by 11am UTC, it'll make it, but we really need real-world usage samples. These are contrived examples from the language creator, not real-world examples of in-the-wild real usage.
ae4615d
to
30eb802
Compare
@lildude I updated the samples with real-world code and rebased off master. Let me know if you need anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I'm going to go the other way and ask you to please replace the large samples (those suppressed in the diff by default) with smaller ones 😁
@lildude do the samples need to be complete and compile on their own, or can they be snippets of a larger file or library? |
They need to be real world examples… we want samples that demonstrate how people really use the language, not contrived hogwash. We don't care if they compile or not as all we're doing is using them to train the classified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your tests are failing because you've got samples in a sub-directory of the Roc
directory. All samples must be directly in the language named directory.
@lildude I updated the samples to match the requirements. Let me know if there are any other issues. |
@ryanb @lildude Would it be better to use a tree-sitter grammar? This one is complete and i suspect would provide better highlighting than a textmate style one: https://github.com/faldor20/tree-sitter-roc |
Nope as linguist has no control over the use of tree-sitter grammars as this is entirely up to the team that maintains the highlighting engine as mentioned previously in #6073. As with the same question in #6689 (comment) this is not likely to happen any time soon given the low usage of this language. |
Ahh, thanks for clarifying, that's a shame. I'll raise this again sometime in the next decade if roc achieves some level of success 😅 |
@lildude any update on the status of this? Do you need anything else from me? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Note: this PR will not be merged until close to when the next release is made. See here for more details.
Thanks for merging! Looking forward to seeing it live. |
This adds syntax grammar for Roc, an up and coming functional language.
@lildude It would be amazing to get this in before 7.28.0 is deployed tomorrow. A lot of us are doing Advent of Code with Roc this year and would really appreciate some syntax highlighting.
Checklist:
#7c38f5