Added The Device Modeling Language (DML) #7009
Conversation
There was a problem hiding this comment.
- For some reason I see 0 repositories. While it's unclear to me if there are 200 unique public repositories.
This will be because that only returns the count of repos with "dml 1.4" in their name.
- Intel has a lot of code internally written in DML but they are unfortunately in private repositories. The same is the case with customer's using Intel Simics to write their device models using DML.
We rely on public usage only as there is no way to query private usage... cos it's private, even to GitHub 😁
Regarding your search query:
This search is quite precise. I assume 1.4 is the version. What about earlier versions? A quick search shows there are some files with dml 1.0, dml 1.2, dml 1.4. Are these the same language?
Your specific search means there are not enough files for this PR to meet our usage requirements (also referenced in the CONTRIBUTING.md file).
If we remove your qualifier, we get a lot more files and things look a bit more promising, however a lot of the files returned don't appear to be the same language as you're proposing with this PR as we can see if we exclude the dml 1 string. As a result, these will all be misidentified as this language if this PR is merged as Linguist doesn't know of any other languages with the .dml extension.
There are far more of those other languages than this language if dml 1.? always has to be in the file, so at least one of those other languages needs to be identified and added at the same time in this PR. Your (relaxed?) heuristic will then be used to differentiate the two.
| - extensions: ['.dml'] | ||
| rules: | ||
| - language: Device Modeling Language | ||
| pattern: '(^dml\s1.4;)' |
There was a problem hiding this comment.
This will have no effect as Linguist doesn't know of any other language that uses the .dml extension. See my primary comment for more details.
There was a problem hiding this comment.
Ah, I was under the impression that if this regex didn't match, and given that there are no other languages in linguist that has a .dml extension, the language of the file would simply not be recognized.
Yes, they are the same language. However, the syntax is quite different between 1.2 and 1.4, and the grammar file only covers 1.4. Do you have any suggestion regarding how this can be handled?
Would you say that if we include 1.0, 1.2 and 1.4 and add also add another language with a |
Even if you add a single entry for all |
|
We (Altera) have plans to public release repos with Simics code in the near future and would greatly benefit from having DML support in linguist. The repos we plan would be FPGA designs with their associated Simics model, in addition to specific training examples on using Simics and modeling. I am aware of at least 4 major engineering companies that use both GitHub and Simics, where this linguist support would benefit them too. Please consider this a very strong endorsement of this PR. |
.dmlas an extension for the DML languageDescription
The Device Modeling Language (DML) is an open source domain-specific language for writing fast functional or transaction-level device models for virtual platforms. DML provides high-level abstractions suitable for functional device models, including constructs like register banks, registers, bit fields, event posting, interfaces between models, and logging. DML code is compiled by the DML Compiler (DMLC), producing C code with API calls tailored for a particular simulator.
Currently, the compiler supports building models for the Intel® Simics® simulator, but other back-ends may be added in the future.
DMLC is maintained by Intel.
#0068B5