Massive Refactor (part II) 🍻 - WIP #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcanessa
force-pushed
the
second-refactor
branch
from
224244c to
cb832f8
Compare
alexcanessa
force-pushed
the
second-refactor
branch
3 times, most recently
from
7450e33 to
d2e4ada
Compare
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
=========================================
Coverage ? 79.27%
=========================================
Files ? 7
Lines ? 333
Branches ? 0
=========================================
Hits ? 264
Misses ? 69
Partials ? 0
Continue to review full report at Codecov.
|
alexcanessa
force-pushed
the
second-refactor
branch
4 times, most recently
from
194605d to
9777c38
Compare
alexcanessa
force-pushed
the
second-refactor
branch
from
ddc0d16 to
bf4eeae
Compare
alexcanessa
force-pushed
the
second-refactor
branch
2 times, most recently
from
c9655cf to
7d7e99d
Compare
alexcanessa
force-pushed
the
second-refactor
branch
from
7d7e99d to
3e808f4
Compare
alexcanessa
force-pushed
the
second-refactor
branch
from
3e808f4 to
51abd84
Compare
alexcanessa
force-pushed
the
second-refactor
branch
from
51abd84 to
097fd67
Compare
alexcanessa
force-pushed
the
second-refactor
branch
from
3054bbf to
a1a8d37
Compare
alexcanessa
added a commit
that referenced
this pull request
Sep 29, 2017
* Add all the defaults to Release.js * First change for README.md file * Create Gren task and add functionality for the changelog command * Update node version in travis * Change the task for the Gren * Update options description * Use native Object.assign for the program options to avoid deep merging * Prettify the utils task logger * Accept * as all tags * Get github env informations from Program.js * Update the generated documentation * Change the name in the docs * Update documentation * Add code coverage with mocha/istanbul * Update organisation name in the package.json * Get the token from process.env rather than command * Update documentation * Create tests * Add npm downloads badge
Merged
alexcanessa
added a commit
that referenced
this pull request
Oct 8, 2017
* Add all the defaults to Release.js * First change for README.md file * Create Gren task and add functionality for the changelog command * Update node version in travis * Change the task for the Gren * Update options description * Use native Object.assign for the program options to avoid deep merging * Prettify the utils task logger * Accept * as all tags * Get github env informations from Program.js * Update the generated documentation * Change the name in the docs * Update documentation * Add code coverage with mocha/istanbul * Update organisation name in the package.json * Get the token from process.env rather than command * Update documentation * Create tests * Add npm downloads badge
This was referenced Oct 8, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a massive PR, indeedDocs
Lot of work of this PR has been done to make the documentation more readable.
Options and Examples
contributes to #66 and #80 (already started in #82).
Options and Examples are now implemented in the
grencommand and both generate yml files in thedocsfolder, to feedjekyll.The documentation now implements the options and the examples shown on the terminal.
README.mdresolves #78
Updated the
README.mdfile to reflect Options and Examples and removed it from thedocswhere now the homepage is just the navigation (don't need a duplicate for that).Testing - currently WIP
resolves #37
Removed
nodeunitand now using the bundlemocha,chai,istanbulandnycto run test and coverage.README.mdfile.Codecovreport on PRs.