Pre-release 0.25.85

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,27 @@
+---
+name: Bug report
+about: Create a report to help us improve GitHub Copilot for Xcode
+---
+
+<!-- Please search existing issues to avoid creating duplicates -->
+
+**Describe the bug**
+<!-- A clear and concise description of what the bug is. -->
+
+**Versions**
+- Copilot for Xcode: [e.g. 0.25.0]
+- Xcode: [e.g. 16.0]
+- macOS: [e.g. 14.6.1]
+
+**Steps to reproduce**
+1. 
+2. 
+
+**Screenshots**
+<!-- Add screenshots or screen recordings to help explain your problem. -->
+
+**Logs**
+<!-- Attach relevant logs from `~/Library/Logs/GitHubCopilot/` -->
+
+**Additional context**
+<!-- Add any other context about the problem here. -->

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,8 @@
+---
+name: Feature request
+about: Suggest an idea for GitHub Copilot for Xcode
+---
+
+<!-- Please search existing issues to avoid creating duplicates -->
+
+<!-- Describe the feature you'd like. -->

CommunicationBridge/main.swift

@@ -1,5 +1,6 @@
 import AppKit
 import Foundation
+import Logger
 
 class AppDelegate: NSObject, NSApplicationDelegate {}
 
@@ -15,5 +16,6 @@ listener.delegate = delegate
 listener.resume()
 let app = NSApplication.shared
 app.delegate = appDelegate
+Logger.communicationBridge.info("Communication bridge started")
 app.run()
 

Copilot-for-Xcode-Info.plist

@@ -2,7 +2,7 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
     <dict>
-        <key></key>
+        <key>APP_ID_PREFIX</key>
         <string>$(AppIdentifierPrefix)</string>
         <key>APPLICATION_SUPPORT_FOLDER</key>
         <string>$(APPLICATION_SUPPORT_FOLDER)</string>

Core/Package.swift

@@ -209,7 +209,12 @@ let package = Package(
         // MARK: - Helpers
 
             .target(name: "FileChangeChecker"),
-        .target(name: "LaunchAgentManager"),
+        .target(
+            name: "LaunchAgentManager",
+            dependencies: [
+                .product(name: "Logger", package: "Tool"),
+            ]
+        ),
         .target(
             name: "UpdateChecker",
             dependencies: [

Core/Sources/HostApp/AdvancedSettings/AdvancedSettings.swift

@@ -0,0 +1,20 @@
+import SwiftUI
+
+struct AdvancedSettings: View {
+    var body: some View {
+        ScrollView {
+            VStack(alignment: .leading, spacing: 30) {
+                SuggestionSection()
+                EnterpriseSection()
+                ProxySection()
+                LoggingSection()
+            }
+            .padding(20)
+        }
+    }
+}
+
+#Preview {
+    AdvancedSettings()
+        .frame(width: 800, height: 600)
+}

Core/Sources/HostApp/FeatureSettings/Suggestion/SuggestionFeatureDisabledLanguageListView.swift → Core/Sources/HostApp/AdvancedSettings/DisabledLanguageList.swift

@@ -15,7 +15,7 @@ extension List {
     }
 }
 
-struct SuggestionFeatureDisabledLanguageListView: View {
+struct DisabledLanguageList: View {
     final class Settings: ObservableObject {
         @AppStorage(\.suggestionFeatureDisabledLanguageList)
         var suggestionFeatureDisabledLanguageList: [String]
@@ -100,16 +100,15 @@ struct SuggestionFeatureDisabledLanguageListView: View {
     }
 }
 
-struct SuggestionFeatureDisabledLanguageListView_Preview: PreviewProvider {
-    static var previews: some View {
-        SuggestionFeatureDisabledLanguageListView(
-            isOpen: .constant(true),
-            settings: .init(suggestionFeatureDisabledLanguageList: .init(wrappedValue: [
-                "hello/2",
-                "hello/3",
-                "hello/4",
-            ], "SuggestionFeatureDisabledLanguageListView_Preview"))
-        )
-    }
+#Preview {
+    DisabledLanguageList(
+        isOpen: .constant(true),
+        settings: .init(suggestionFeatureDisabledLanguageList: .init(wrappedValue: [
+            "hello/2",
+            "hello/3",
+            "hello/4",
+        ], "SuggestionFeatureDisabledLanguageListView_Preview"))
+    )
 }
 
+

Core/Sources/HostApp/AdvancedSettings/EnterpriseSection.swift

@@ -0,0 +1,19 @@
+import SwiftUI
+
+struct EnterpriseSection: View {
+    @AppStorage(\.gitHubCopilotEnterpriseURI) var gitHubCopilotEnterpriseURI
+
+    var body: some View {
+        SettingsSection(title: "Enterprise") {
+            SettingsTextField(
+                title: "Auth provider URL",
+                prompt: "Leave it blank if none is available.",
+                text: $gitHubCopilotEnterpriseURI
+            )
+        }
+    }
+}
+
+#Preview {
+    EnterpriseSection()
+}

Core/Sources/HostApp/AdvancedSettings/LoggingSection.swift

@@ -0,0 +1,52 @@
+import Logger
+import SwiftUI
+
+struct LoggingSection: View {
+    @AppStorage(\.verboseLoggingEnabled) var verboseLoggingEnabled: Bool
+    @State private var shouldPresentRestartAlert = false
+
+    var verboseLoggingBinding: Binding<Bool> {
+        Binding(
+            get: { verboseLoggingEnabled },
+            set: {
+                verboseLoggingEnabled = $0
+                shouldPresentRestartAlert = $0
+            }
+        )
+    }
+
+    var body: some View {
+        SettingsSection(title: "Logging") {
+            SettingsToggle(
+                title: "Verbose Logging",
+                isOn: verboseLoggingBinding
+            )
+            Divider()
+            SettingsLink(
+                URL(fileURLWithPath: FileLoggingLocation.path.string),
+                title: "Open Copilot Log Folder"
+            )
+            .environment(\.openURL, OpenURLAction { url in
+                NSWorkspace.shared.open(url)
+                return .handled
+            })
+        }
+        .alert(isPresented: $shouldPresentRestartAlert) {
+            Alert(
+                title: Text("Quit And Restart Xcode"),
+                message: Text(
+                    """
+                    Logging level changes will take effect the next time Copilot \
+                    for Xcode is started. To update logging now, please quit \
+                    Copilot for Xcode and restart Xcode.
+                    """
+                ),
+                dismissButton: .default(Text("OK"))
+            )
+        }
+    }
+}
+
+#Preview {
+    LoggingSection()
+}

Core/Sources/HostApp/AdvancedSettings/ProxySection.swift

@@ -0,0 +1,65 @@
+import Client
+import SwiftUI
+import Toast
+
+struct ProxySection: View {
+    @AppStorage(\.gitHubCopilotProxyUrl) var gitHubCopilotProxyUrl
+    @AppStorage(\.gitHubCopilotProxyUsername) var gitHubCopilotProxyUsername
+    @AppStorage(\.gitHubCopilotProxyPassword) var gitHubCopilotProxyPassword
+    @AppStorage(\.gitHubCopilotUseStrictSSL) var gitHubCopilotUseStrictSSL
+
+    @Environment(\.toast) var toast
+
+    var body: some View {
+        SettingsSection(title: "Proxy") {
+            SettingsTextField(
+                title: "Proxy URL",
+                prompt: "http://host:port",
+                text: $gitHubCopilotProxyUrl
+            )
+            SettingsTextField(
+                title: "Proxy username",
+                prompt: "username",
+                text: $gitHubCopilotProxyUsername
+            )
+            SettingsSecureField(
+                title: "Proxy password",
+                prompt: "password",
+                text: $gitHubCopilotProxyPassword
+            )
+            SettingsToggle(
+                title: "Proxy strict SSL",
+                isOn: $gitHubCopilotUseStrictSSL
+            )
+        } footer: {
+            HStack {
+                Spacer()
+                Button("Refresh configurations") {
+                    refreshConfiguration()
+                }
+            }
+        }
+    }
+
+    func refreshConfiguration() {
+        NotificationCenter.default.post(
+            name: .gitHubCopilotShouldRefreshEditorInformation,
+            object: nil
+        )
+        Task {
+            let service = try getService()
+            do {
+                try await service.postNotification(
+                    name: Notification.Name
+                        .gitHubCopilotShouldRefreshEditorInformation.rawValue
+                )
+            } catch {
+                toast(error.localizedDescription, .error)
+            }
+        }
+    }
+}
+
+#Preview {
+    ProxySection()
+}

Core/Sources/HostApp/AdvancedSettings/SuggestionSection.swift

@@ -0,0 +1,62 @@
+import SwiftUI
+
+struct SuggestionSection: View {
+    @AppStorage(\.realtimeSuggestionToggle) var realtimeSuggestionToggle
+    @AppStorage(\.suggestionFeatureEnabledProjectList) var suggestionFeatureEnabledProjectList
+    @AppStorage(\.acceptSuggestionWithTab) var acceptSuggestionWithTab
+    @State var isSuggestionFeatureDisabledLanguageListViewOpen = false
+    @State private var shouldPresentTurnoffSheet = false
+
+    var realtimeSuggestionBinding : Binding<Bool> {
+        Binding(
+            get: { realtimeSuggestionToggle },
+            set: {
+                if !$0 {
+                    shouldPresentTurnoffSheet = true
+                } else {
+                    realtimeSuggestionToggle = $0
+                }
+            }
+        )
+    }
+
+    var body: some View {
+        SettingsSection(title: "Suggestion Settings") {
+            SettingsToggle(
+                title: "Request suggestions while typing",
+                isOn: realtimeSuggestionBinding
+            )
+            Divider()
+            SettingsToggle(
+                title: "Accept suggestions with Tab",
+                isOn: $acceptSuggestionWithTab
+            )
+        } footer: {
+            HStack {
+                Spacer()
+                Button("Disabled language list") {
+                    isSuggestionFeatureDisabledLanguageListViewOpen = true
+                }
+            }
+        }
+        .sheet(isPresented: $isSuggestionFeatureDisabledLanguageListViewOpen) {
+            DisabledLanguageList(isOpen: $isSuggestionFeatureDisabledLanguageListViewOpen)
+        }
+        .alert(
+            "Disable suggestions while typing",
+            isPresented: $shouldPresentTurnoffSheet
+        ) {
+            Button("Disable") { realtimeSuggestionToggle = false }
+            Button("Cancel", role: .cancel, action: {})
+        } message: {
+            Text("""
+                If you disable requesting suggestions while typing, you will \
+                not see any suggestions until requested manually.
+                """)
+        }
+    }
+}
+
+#Preview {
+    SuggestionSection()
+}