-
Couldn't load subscription status.
- Fork 1.2k
Various unit test fixes. #1997
Various unit test fixes. #1997
Conversation
It should not be necessary.
Unit tests require a CurrentThreadScheduler to be used, RxUI's registrations were overriding that, causing intermittent test failures.
This should now work correctly, and greatly speeds up the tests.
Sometimes unit tests were failing to find the nativate libgit2sharp binaries under ncrunch. This fixes that.
Hopefully will be less flaky now?
Codecov Report
@@ Coverage Diff @@
## master #1997 +/- ##
==========================================
- Coverage 41.7% 40.28% -1.42%
==========================================
Files 373 405 +32
Lines 16126 17347 +1221
Branches 2211 2392 +181
==========================================
+ Hits 6725 6988 +263
- Misses 8890 9837 +947
- Partials 511 522 +11
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm this is working a lot better! 🎉
When I first tried it, I forget to update the ReactiveUI submodule and tests were breaking all over the place. Updating the submodule turned (almost) everything green!
We still have a troublesome FilterTitleRun2 flaky test. Shall we disable it at part of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggested change. Merge at will....
Co-Authored-By: grokys <grokys@github.com>

Various unit test fixes:
TestUtils.WithScheduler(Scheduler.CurrentThread)hacks