Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Adding indications for protected branches #2029

Merged
merged 12 commits into from
Dec 13, 2018

Conversation

StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Nov 2, 2018

This pull request depends on:

This pull request adds "required" labels in the Pull Request Checks list.
image

Needs some 💓 from @donokuda

@StanleyGoldman StanleyGoldman changed the title Adding indications for protected branches [WIP] Adding indications for protected branches Nov 2, 2018
@StanleyGoldman
Copy link
Contributor Author

# Conflicts:
#	src/GitHub.App/Services/PullRequestService.cs
#	src/GitHub.App/ViewModels/GitHubPane/PullRequestCheckViewModel.cs
#	src/GitHub.Exports.Reactive/Collections/TrackingCollection.cs
#	src/GitHub.Exports.Reactive/ViewModels/GitHubPane/IPullRequestDetailViewModel.cs
#	src/GitHub.Exports/Models/CheckRunModel.cs
#	src/GitHub.VisualStudio.UI/Views/GitHubPane/PullRequestCheckView.xaml
#	test/GitHub.App.UnitTests/ViewModels/GitHubPane/PullRequestCreationViewModelTests.cs
# Conflicts:
#	src/GitHub.VisualStudio.UI/Views/GitHubPane/PullRequestCheckView.xaml
@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

❗ No coverage uploaded for pull request base (check-second-line@a489cbe). Click here to learn what that means.
The diff coverage is 3.12%.

@@                 Coverage Diff                  @@
##             check-second-line    #2029   +/-   ##
====================================================
  Coverage                     ?   38.89%           
====================================================
  Files                        ?      411           
  Lines                        ?    17679           
  Branches                     ?     2447           
====================================================
  Hits                         ?     6876           
  Misses                       ?    10256           
  Partials                     ?      547
Impacted Files Coverage Δ
...rc/GitHub.Exports/Models/PullRequestDetailModel.cs 100% <ø> (ø)
...Exports.Reactive/Collections/TrackingCollection.cs 57.82% <ø> (ø)
src/GitHub.App/Services/RepositoryService.cs 0% <0%> (ø)
...ViewModels/GitHubPane/PullRequestCheckViewModel.cs 1.06% <0%> (ø)
src/GitHub.Exports/Models/ProtectedBranch.cs 0% <0%> (ø)
...wModels/GitHubPane/PullRequestListItemViewModel.cs 61.11% <0%> (ø)
src/GitHub.Exports/Models/StatusModel.cs 0% <0%> (ø)
src/GitHub.App/Services/RepositoryCloneService.cs 49.48% <0%> (ø)
src/GitHub.Exports/Models/CheckRunModel.cs 0% <0%> (ø)
src/GitHub.App/Services/PullRequestService.cs 32.29% <1.96%> (ø)
... and 2 more

@StanleyGoldman StanleyGoldman changed the base branch from master to check-second-line December 13, 2018 15:30
@StanleyGoldman StanleyGoldman changed the title [WIP] Adding indications for protected branches Adding indications for protected branches Dec 13, 2018
@StanleyGoldman StanleyGoldman merged commit bda657a into check-second-line Dec 13, 2018
@StanleyGoldman StanleyGoldman deleted the protected-branches branch December 13, 2018 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants