Checkbox styling fix for #62

[shana]

Fixes #62

This fixes the checkbox styling so it still matches Team Explorer but doesn't break our reactive bindings.

The previous style was using an inner checkbox for the rendering, and when reactiveui binds the view to the viewmodel, it likely looks for changed properties in the RoutedEventArgs Source or possibly the sender object that goes along with the event, and both of these represent the outer checkbox, which is not the originator of the Checked event, so it doesn't actually have the IsChecked property set.

This caused the UI to appear correct (inner checkbox is set), but the binding to not pick up the change (outer checkbox not set).

[shiftkey]

Pulled this down to test, and yes I can see the checkbox state updating the VM property correctly ✨

@shana anything else you'd like us to focus on with the review?

[shana]

@shiftkey One of the reasons things broke is that I tried to make a style combining the CheckBox and the TextBlock without recreating the checkbox style (because I have no clue what it is). Is there a better way of doing this than what I'm doing now (adding the textblock inside the checkbox directly in the xaml publish control)?

[shiftkey]

You can strip this back to just the literal Private Repository element - this will get rendered as an inline TextBlock and pick up the styling...

[shana]

Ah, right, I can move the trigger up to the checkbox

/me fixicates

[shana]

Sigh, can't merge the TextBlock. If I do, then the Hover color in the checkbox (turning the square border a different color) also gets applied to the text. Which is something that the TE styles are not doing, it seems.

[shiftkey]

Uggghh 👍

[shana]

@haacked 👀 👍 👎?

[haacked]

If @shiftkey gives a 👍 then I'm a 👍!