Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHSA-xqr8-7jwr-rhp7] Removal of e-Tugra root certificate #2622

Conversation

crimsonknave
Copy link

@crimsonknave crimsonknave commented Aug 15, 2023

Updates

  • Affected products

Comments
There is no 0 in the fix version. https://pypi.org/project/certifi/#history

This causes grype to detect the updated package as not being fixed since the version string is different.
/cc anchore/grype#1430

@github
Copy link
Collaborator

github commented Aug 15, 2023

Hi there @alex! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our highly-trained Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

@github-actions github-actions bot changed the base branch from main to crimsonknave/advisory-improvement-2622 August 15, 2023 19:09
@alex
Copy link

alex commented Aug 15, 2023

This is fine, though I'll note that tooling should be prepared to deal with versions like this. It's clearly spelled out in PEP 440: https://peps.python.org/pep-0440/#integer-normalization

@crimsonknave
Copy link
Author

Yeah, that makes sense, tools should handle things like this, but sadly they don't always.

I believe that you will need to submit a PR review for the approval for the change to get merged.

@advisory-database advisory-database bot merged commit 30ccfe1 into crimsonknave/advisory-improvement-2622 Aug 16, 2023
@advisory-database advisory-database bot deleted the crimsonknave-GHSA-xqr8-7jwr-rhp7 branch August 16, 2023 19:36
@advisory-database
Copy link
Contributor

Hi @crimsonknave! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants