[GHSA-r58r-74gx-6wx3] Nokogiri gem, via libxml, is affected by DoS vulnerabilities #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the base branch from
main
to
owst/advisory-improvement-2655
|
Thanks @owst - this false positive noise must be on nearly every ruby project in the ecosystem. Pretty frustrating lack of quality control here to get the versions all wrong given the noise it creates :( The specific commit which confirms the fixed tag version is sparklemotion/nokogiri@1756096 from sparklemotion/nokogiri#1689 and sparklemotion/nokogiri#1688 |
|
Hmm, I'm not sure what's gone on here - this PR was closed without merging and no (obvious) other change was committed to correct the advisory. The PR was created via https://github.com/advisories/GHSA-r58r-74gx-6wx3/improve |
|
I’m not sure either. The branch hijinx and bot automation here is a mystery to me. |
This was referenced Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Comments
The nokogiri version is different to the underlying libxml version. As per this comment (and the following one) nokogiri 1.8.2 includes libxml 2.9.7 and thus addresses CVE-2017-15412
sparklemotion/nokogiri#1714 (comment)