Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHSA-pj7m-g53m-7638] Bootstrap Cross-site Scripting vulnerability #3285

Merged

Conversation

jenhae
Copy link

@jenhae jenhae commented Jan 15, 2024

Updates

  • Affected products
  • Description

Comments
I used the example of twbs/bootstrap#26627 (comment) and modified the bootstrap version to one below the formerly stated patched version 3.4.0 and couldn't verify the issue see https://jsbin.com/jafujoqage/edit?html,output

@github-actions github-actions bot changed the base branch from main to jenhae/advisory-improvement-3285 January 15, 2024 11:06
@shelbyc
Copy link
Contributor

shelbyc commented Jan 16, 2024

Hi @jenhae, my colleague @JonathanLEvans and I worked together and found the commit that introduced the vulnerable code in version 4.0.0-alpha6. twbs/bootstrap@c2616fb#diff-1d84c75bd9722a89a7db565ca8061c7b2c7657ed908a9cb2a2feb1124537429b shows where const targets = $.makeArray($(this._selector)), the line that was fixed in https://github.com/twbs/bootstrap/pull/26630/files#diff-1d84c75bd9722a89a7db565ca8061c7b2c7657ed908a9cb2a2feb1124537429b. Even searching for let targets = $.makeArray($(this._selector)) led me to this commit where the line was added in scrollspy.js in the 4.x branch, and I was unable to find let targets = $.makeArray($(this._selector)) in any 3.x versions. Because your findings are consistent with evidence in the source code, we are accepting this contribution.

@advisory-database advisory-database bot merged commit 0eb32c5 into jenhae/advisory-improvement-3285 Jan 16, 2024
2 checks passed
@advisory-database
Copy link
Contributor

Hi @jenhae! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future!

@advisory-database advisory-database bot deleted the jenhae-GHSA-pj7m-g53m-7638 branch January 16, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants