Skip to content

Conversation

@dreadwitdastacc-IFA
Copy link

Updates

  • CVSS v3

Comments
if (root === '[]' && options.parseArrays) {
// Use currentArrayLength already calculated at line 147-151
if (options.throwOnLimitExceeded && currentArrayLength >= options.arrayLimit) {
throw new RangeError('Array limit exceeded. Only ' + options.arrayLimit + ' element' + (options.arrayLimit === 1 ? '' : 's') + ' allowed in an array.');
}

// If limit exceeded and not throwing, convert to object (consistent with indexed notation behavior)
if (currentArrayLength >= options.arrayLimit) {
    obj = options.plainObjects ? { __proto__: null } : {};
    obj[currentArrayLength] = leaf;
} else {
    obj = options.allowEmptyArrays && (leaf === '' || (options.strictNullHandling && leaf === null))
        ? []
        : utils.combine([], leaf);
}

}

@github
Copy link
Collaborator

github commented Jan 8, 2026

Hi there @ljharb! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

Copilot AI review requested due to automatic review settings January 8, 2026 07:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates a GitHub Security Advisory (GHSA-6rw7-vpxm-498p) for a denial-of-service vulnerability in the qs library by removing the CVSS v3 severity score while retaining the CVSS v4 score.

Key changes:

  • Removed CVSS v3.1 severity scoring from the advisory
  • Updated the modification timestamp to reflect the change

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Author

@dreadwitdastacc-IFA dreadwitdastacc-IFA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bracket notation

@github-actions github-actions bot changed the base branch from main to dreadwitdastacc-IFA/advisory-improvement-6628 January 8, 2026 07:28
@JonathanLEvans JonathanLEvans added the invalid This doesn't seem right label Jan 8, 2026
@github-actions github-actions bot deleted the dreadwitdastacc-IFA-GHSA-6rw7-vpxm-498p branch January 8, 2026 15:10
Copy link
Author

@dreadwitdastacc-IFA dreadwitdastacc-IFA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invailid\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants