Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade packages tests exports #62

Merged
merged 5 commits into from
Apr 20, 2023
Merged

Conversation

keithamus
Copy link
Member

@keithamus keithamus commented Apr 20, 2023

This upgrades this package to fall in line with the improvements made in our most recently updated Web Component, the relative-time-element.

The development changes are:

  • Uses web-test-runner over karma.
  • Uses a slightly improved eslint config
  • Minor changes to TSconfig
  • Uses esbuild over rollup

User faces changes are:

  • Emits JSX types, making it compatible with React
  • Reworks exports allowing for various patterns, including importing the web component without defining, or defining under different scopes or registries.
  • Outputs a custom elements manifest.

Refs https://github.com/github/primer/issues/2138

@keithamus keithamus requested a review from a team as a code owner April 20, 2023 10:31
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants