Support alternative HTTP methods #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change proposed supporting the use of alternative HTTP methods. For example, now a user can define `http-method=GET` and then component will issue a `GET` request using encoded query params instead. All values other than POST will use this new approach. The default remains POST.
keithamus
reviewed
May 24, 2024
keithamus
reviewed
May 24, 2024
keithamus
reviewed
May 24, 2024
keithamus
reviewed
May 24, 2024
keithamus
reviewed
May 24, 2024
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
srt32
commented
May 24, 2024
srt32
commented
May 24, 2024
srt32
commented
May 24, 2024
keithamus
approved these changes
May 24, 2024
|
I've added a spec as well as some other tweaks (that are less elegant than I would like). |
keithamus
approved these changes
May 29, 2024
src/auto-check-element.ts
Outdated
| @@ -176,6 +176,10 @@ export class AutoCheckElement extends HTMLElement { | |||
| set csrfField(value: string) { | |||
| this.setAttribute('csrf-field', value) | |||
| } | |||
|
|
|||
| get httpMethod(): string { | |||
| return this.getAttribute('http-method') || 'POST' | |||
There was a problem hiding this comment.
This should probably just return allowed values, eg just GET or POST. Otherwise this allows for arbotrary verbs. Might lead to undesired behaviour.
We can ship this and bugfix later if time is of the essence.
keithamus
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change proposed supporting the use of alternative HTTP methods.
For example, now a user can define
http-method=GETand then component will issue aGETrequest using encoded query params instead. All values other than POST will use this new approach. The default remains POST.