-
Notifications
You must be signed in to change notification settings - Fork 1.3k
add update-code-from-shorthand instructions #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new custom instruction file for updating code from shorthand notation and adds it to the instructions catalog. The PR also appears to have updated all description entries in the README table, though many of these changes appear to be unintentional modifications.
Key Changes
- Adds a new instruction file
update-code-from-shorthand.instructions.mdfor converting shorthand notation to production code - Inserts the new instruction entry into the alphabetically-sorted README table at position 120
- Updates description entries across the entire README table (appears to be unintentional bulk changes)
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| instructions/update-code-from-shorthand.instructions.md | New instruction file defining shorthand-to-code conversion guidelines |
| docs/README.instructions.md | Adds new instruction entry and modifies existing descriptions |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Wanted the example instructions to be functional, and illustrate better how to correctly use the instructions; so I changed the bottom example a bit. For proof of concept I used an example file like the one in the instructions, and used the prompt from the updated example. With just that the agent produced a basic markdown to html converter. See support-repo for an example of - well, the example. |
aaronpowell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like something is up with the changes in the README, as there's a lot unrelated to the new instruction being added.
Can you update with main and re-run
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.Description
This allows the agent to look at a code file and make updates where marked lines like
()=> for x in y do z++;where the agent takes context from current file and applies the changes. And applies the changes really good (if I might say). I tested it using this in a prompt:It created a new file
scripts/indent-nested-md-code.js, which worked; but not perfect. So - then several tweaks like:#file:indent-nested-md-code.js indent 4 spaces and not 3.and
And the end result - pushed them to another branch where you can see the difference at indent-nested-md-code.
Type of Contribution
Additional Notes
I add trouble with
npm start. I had to modify theeng/yaml-parser.js,package.json, andpackage-lock.jsonto get it to work, runninggit restore .after adding thedocs/README.instructions.mdthat was relevant to this pull request.By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.