Skip to content

Conversation

@anchildress1
Copy link
Contributor

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • My contribution adds a new instruction, prompt, or chat mode file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, or chat mode with GitHub Copilot.
  • I have run npm start and verified that README.md is up to date.

Description

@aaronpowell
I realize I probably should have started a discussion first, but I started out just playing with the contributors library and got a little carried away 😆 Tbh, I'm not incredibly attached—I just hate wasting code when it could be useful. Let me know if you want changes or something taken back out!

  • Configure custom contribution types for instructions, prompts, agents, and collections
  • Add check for missing contributors to weekly GHA workflow file output to summary
  • Include ignore list (in case users request to be removed from README)
  • Create script that pulls from all-contributors CLI check and auto-adds contributor based on merged PRs

Type of Contribution

  • New instruction file.
  • New prompt file.
  • New chat mode file.
  • New collection file.
  • Update to existing instruction, prompt, chat mode, or collection.
  • Other (please specify):
    • Enhancement to align contributors with types specific to this repo.

Additional Notes

I had to stop myself from adding a bot that does all this for you automatically! I figure less is safer, so I kept everything to the report-friendly version and an auto-add script strictly for local use. That last one I wasn't going to include at all, but then decided it could be used for automation later if one were so inclined.

This is what that report looks like with markdown formatted in workflow output summary:

Screenshot 2025-12-20 at 12 19 41 AM

By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

- Add eng/README.md documenting maintainer utilities
- Add eng/contributor-report.mjs for generating contributor reports
- Add eng/add-missing-contributors.mjs for automating contributor additions
- Add eng/utils/graceful-shutdown.mjs for script lifecycle management
- Update eng/update-readme.mjs with minor fixes
- Update package.json with new contributor scripts

Generated-by: GitHub Copilot <copilot@github.com>
Signed-off-by: Ashley Childress <6563688+anchildress1@users.noreply.github.com>
- Modify generateMarkdownReport to include per-user sections with PR details
- Remove total PR count and simplify PR link format

Commit-generated-by: GitHub Copilot <copilot@github.com>
Signed-off-by: Ashley Childress <6563688+anchildress1@users.noreply.github.com>
Copilot AI review requested due to automatic review settings December 20, 2025 05:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the contributor recognition system by adding custom contribution types specific to this repository (instructions, prompts, agents, collections) and implements automated contributor detection and reporting tooling.

Key changes:

  • Custom contributor types configured in .all-contributorsrc to better reflect repo-specific contributions
  • New contributor reporting scripts that analyze merged PRs and detect missing contributors
  • Updated CI workflow to automatically check and report missing contributors weekly

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
.all-contributorsrc Adds custom contribution types (instructions, prompts, agents, collections), ignore list, and migrates existing contributors to new types
package.json Adds contributors:report script and updates keywords
eng/contributor-report.mjs New script to generate markdown reports of missing contributors by analyzing merged PRs
eng/add-missing-contributors.mjs New script to automatically add missing contributors with inferred contribution types
eng/utils/graceful-shutdown.mjs Utility for graceful shutdown handling in Node scripts
eng/README.md Documentation for the new contributor tooling
.github/workflows/contributors.yml Updates workflow to check/report missing contributors and adds timeout
CONTRIBUTING.md Documents the new contributor recognition process and custom types
README.md Auto-generated changes reflecting new contributor types and badge updates
.gitignore Excludes reports directory from version control

Copy link
Contributor

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooo nifty, I didn't know you could do something like this.

There are some comments from Copilot on the regexes and stuff, can you review to see if any are actually valid

- eng/contributor-report.mjs: condensed per-user layout; emit per-PR fenced plaintext snippets; removed normalizeOneLine()

Generated-by: GitHub Copilot <copilot@github.com>
Signed-off-by: Ashley Childress <6563688+anchildress1@users.noreply.github.com>
…ssues

- Improve contributor-report.mjs based on Copilot comments and sonar
- Use fileURLToPath for Windows-safe main checks in contributor scripts
- Fix README badge URLs by removing duplicate style parameters
- Update graceful-shutdown.mjs to throw on process.exit failure for better error visibility

Generated-by: GitHub Copilot <copilot@github.com>
Signed-off-by: Ashley Childress <6563688+anchildress1@users.noreply.github.com>
- Improve errors in contributor-report.mjs
- Add missing `skills` to custom contribution types list and docs
- Refresh existing contributors

Assisted-by: GitHub Copilot <copilot@github.com>
Signed-off-by: Ashley Childress <6563688+anchildress1@users.noreply.github.com>
@anchildress1
Copy link
Contributor Author

@aaronpowell I've got some basic changes made, but let me do some more validation testing before this gets merged. I'll post back with test results.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 10 changed files in this pull request and generated 4 comments.

- Replace brittle grep check with exit code-based branching
- Use continue-on-error and conditional report generation

Generated-by: GitHub Copilot <copilot@github.com>
Signed-off-by: Ashley Childress <6563688+anchildress1@users.noreply.github.com>
@anchildress1
Copy link
Contributor Author

@aaronpowell It's good now 😄 Output is the same as before. I went ahead and added the missing skills section, too, and refreshed everything again. If anybody wants to explicitly opt-out of being displayed you can add their GH username to the .all-contributorsrc file, which I repurposed for that specifically. Also useful if any other bots start showing up on the report.

Let's let it run for awhile and lmk if you want to try to automate any more out of it. I left the oneadd-missing-contributors file in there, just in case. Or you can nix it if it gets in the way. It's not actually used anywhere asides from me refreshing everything locally.

@aaronpowell aaronpowell merged commit 204b6b0 into github:main Jan 16, 2026
2 checks passed
@anchildress1 anchildress1 deleted the add-custom-contributors branch January 16, 2026 04:17
@anchildress1
Copy link
Contributor Author

@all-contributors please add @anchildress1 for infra, doc, code

@allcontributors
Copy link
Contributor

@anchildress1

I've put up a pull request to add @anchildress1! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants