-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check existence of clipboard in navigator #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this!
Btw, following error is rapidly popping up (thousands within seconds) in current github webpage:
It wasn't hard to catch :) It was way harder to find this repo :) |
We'll also need to guard against this in the other methods- |
Ah, I see, I didn't realize that when I was comparing it with |
I addressed it somehow... |
Glad to see this is fixed -- just tracked it down myself. I think this is what's causing github to be slow and have very high CPU use whenever it's open. Any idea when it's getting into production? |
@dylex yes, this exactly what I am experiencing, very high CPU use, lots of exceptions. |
This fixes an issue I have encountered recently in Github webpage in my web browser, where
clipboard
is not defined innavigator
. I believe its presence should be checked before touching its items in similar fashion like otherisSupported
methods do. This PR is related to #18.