add checkVisibility #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
force-pushed
the
add-checkvisibility
branch
from
caa52c6
to
d0748d4
Compare
erinnachen
previously approved these changes
Oct 20, 2023
keithamus
force-pushed
the
add-checkvisibility
branch
from
d0748d4
to
a5df092
Compare
erinnachen
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
checkVisibilitypolyfill which can be useful to check if an element isn't visible.This method is quite new, Chrome 105+ and Firefox 106+ support it, and WebKit just merged their implementation 2 days ago (WebKit/WebKit#19210) so it'll likely land in Safari.
We want to use it in primer/view_components#2292 so figured the polyfill would be best placed here.