remove autoshadowroot #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koddsson
approved these changes
May 4, 2022
keithamus
force-pushed
the
remove-autoshadowroot
branch
from
9b0b963 to
3cbdd46
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catalyst includes a feature which scans for
<template data-shadowroot>elements and loads them as a shadowdom, however Declarative shadow DOM is now a thing supported in Chrome 90+, Edge 91+, with neutral signals from other vendors.It would make more sense for engineers to use declarative shadow DOM, perhaps with a polyfill, instead of this approach. We've been wanting to remove this for a while, so it makes sense that this be removed in v2.