Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor target into targetable #257

Merged
merged 4 commits into from
May 26, 2022
Merged

refactor target into targetable #257

merged 4 commits into from
May 26, 2022

Conversation

keithamus
Copy link
Member

This refactors target into an ability. We're also changing some of the semantics to give it new super powers:

  • It will dasherise the names to maintain consistency with attr and the custom element name (but fall back to camelcase)
  • You can have a setter that gets triggered when the element changes!
  • We also now query closed shadow roots!

@keithamus keithamus force-pushed the refactor-targets-to-targetable branch 2 times, most recently from 1fca3e0 to 725fdcd Compare May 26, 2022 09:01
@keithamus keithamus force-pushed the refactor-targets-to-targetable branch from 725fdcd to 1b1c52d Compare May 26, 2022 09:03
@keithamus keithamus marked this pull request as ready for review May 26, 2022 09:07
@keithamus keithamus requested a review from a team as a code owner May 26, 2022 09:07
@keithamus keithamus merged commit d0028c5 into v2 May 26, 2022
@keithamus keithamus deleted the refactor-targets-to-targetable branch May 26, 2022 09:54
@keithamus keithamus mentioned this pull request May 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koddsson koddsson koddsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keithamus @koddsson