Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for domains with underscores and fix roundtrip behavior #292

Merged

Conversation

kevinbackhouse
Copy link
Collaborator

Add a test for the underscore logic in check_domain in the autolink extension.

I had to make a minor change to the code to get the "roundtrip" test to pass. The roundtrip test checks that converting to commonmark first and then to html gives the same result as converting directly to html. The first step converts the underscore to \_ which gets handled differently by the logic in check_domain. Adding some code to skip the \ character fixes it.

@kevinbackhouse kevinbackhouse changed the title Add test for domains with underscores and fix roundtrip behavior. Add test for domains with underscores and fix roundtrip behavior Nov 2, 2022
@kevinbackhouse kevinbackhouse merged commit ec05e4f into github:master Jan 23, 2023
@kevinbackhouse kevinbackhouse deleted the domains-with-underscores branch January 23, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants